Add FP16 support #257
Open
Add FP16 support #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahcc
commented
Dec 28, 2024
•
micahcc
commented
- Adds support for floating point-16 bit images
- Use the half crate since half precision floats are nightly only
- added several tests of different features, including prediction
fintelia
reviewed
Dec 28, 2024
fintelia
approved these changes
Jan 14, 2025
micahcc
force-pushed
the
main
branch
2 times, most recently
from
a8fdc9d to
77a22d6
Compare
|
@fintelia I removed the previous image which I had pulled from the internet and switched to images generated with gimp. I relinquish all rights. |
- add predictor for fp16 - add support for reading half (fp16) images - add a pure white test image (generated with gimp) - add predictor tests
micahcc
force-pushed
the
main
branch
2 times, most recently
from
166282b to
2d98a70
Compare
|
@fintelia how do I merge this? |
|
It looks like half doesn't build with 1.61, should this be feature flagged then? |
|
Should be fine to bump the MSRV to 1.70. That'll require changes in Cargo.toml and .github/workflows/rust.yml |
fintelia
reviewed
Jan 31, 2025
added 2 commits
January 31, 2025 14:20
This reverts commit c2cb3d1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.